Skip to content

Update _read_register #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

Update _read_register #6

merged 1 commit into from
Jun 25, 2019

Conversation

caternuson
Copy link
Contributor

Another fix for #4, which was closed but recently popped back up on radar.

Return matches requested length to better align with use of unpack.

pi@pizerow:~/repos/Adafruit_CircuitPython_MAX31856 $ python3
Python 3.7.3 (default, Apr  3 2019, 05:39:12) 
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import board, busio
>>> import digitalio
>>> import adafruit_max31856
>>> spi = busio.SPI(board.SCK, board.MOSI, board.MISO)
>>> cs = digitalio.DigitalInOut(board.D21)
>>> cs.direction = digitalio.Direction.OUTPUT
>>> tc = adafruit_max31856.MAX31856(spi, cs)
>>> tc.temperature
22.1796875
>>> tc.reference_temperature
22.828125
>>>

@ladyada
Copy link
Member

ladyada commented Jun 25, 2019

can merge when travis passes!

@caternuson caternuson mentioned this pull request Jun 25, 2019
Closed
@caternuson caternuson merged commit 6d96de3 into adafruit:master Jun 25, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 26, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@695f1dc)
2685ba7 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31856 to 0.8.3 from 0.8.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31856#6 from caternuson/iss4pt2

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_VCNL4040, Adafruit_CircuitPython_turtle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caternuson @ladyada