Skip to content

Feature/add typing #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Feature/add typing #21

merged 4 commits into from
Oct 28, 2021

Conversation

tekktrik
Copy link
Member

Add typing to functions

@tekktrik tekktrik mentioned this pull request Oct 24, 2021
21 tasks
@tekktrik
Copy link
Member Author

Updated to address issues discovered by workflow

@kattni kattni requested a review from FoamyGuy October 27, 2021 20:42
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @tekktrik

tested on FunHouse with simpletest

@FoamyGuy FoamyGuy merged commit b868341 into adafruit:main Oct 28, 2021
@tekktrik
Copy link
Member Author

My pleasure!

@tekktrik tekktrik deleted the feature/add-typing branch October 28, 2021 02:21
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 28, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 1.2.9 from 1.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#21 from tekktrik/feature/add-typing
  > add docs link to readme
  > Globally disabled consider-using-f-string pylint check
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants