Update _reset() #13
Merged
Update _reset() #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
requested changes
Dec 6, 2021
adafruit_ltr390.py
Outdated
| # The LTR390 software reset is ill behaved and can leave I2C bus in bad state. | ||
| # Instead, just manually set register reset values per datasheet. | ||
| with self.i2c_device as i2c: | ||
| i2c.write(bytes([_CTRL, 0x00])) |
There was a problem hiding this comment.
can ya make these () tuples instead of [] lists
ladyada
approved these changes
Dec 6, 2021
|
🤷♂️ |
|
🤷 |
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 7, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.3.0 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#17 from jposada202020/adding_critical_temp_features > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR390 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_LTR390#13 from caternuson/iss11 > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#15 from romilly/master > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Eddystone to 1.0.7 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Eddystone#15 from tekktrik/docfix/add-blinka-req > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #11.
Tried various ways to "reset" the I2C bus, but none were successful. So did something simple instead. This PR is not an elegant solution, but does resolve issue.