Skip to content

adding compass example #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2020
Merged

adding compass example #4

merged 3 commits into from
Feb 7, 2020

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Feb 7, 2020

This adds the compass example from the old PR referenced in issue #2

@caternuson
Copy link

@FoamyGuy I restarted the CI run on your last commit. It was failing due to 404s when installing deps that just got fixed in another repo.

Now it's failing for pylint reasons. In case you don't know the trick, just unpack the unused z into _.

    magnet_x, magnet_y, _ = _sensor.magnetic

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Feb 7, 2020

@caternuson Thank you. I did not know the underscore trick, thank you for that as well. I've updated the code with that change.

@FoamyGuy FoamyGuy requested a review from a team February 7, 2020 19:21
Copy link

@caternuson caternuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kattni kattni merged commit a0537aa into adafruit:master Feb 7, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants