Add type annotations #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tekktrik merged 4 commits into adafruit:main from tekktrik:dev/add-typing

Aug 15, 2022

Member

tekktrik commented Jul 13, 2022

Resolves #17 by adding type annotations

tekktrik added 4 commits

July 13, 2022 00:03


          Remove unnecessary pass statement

ea7bea0


          Remove other unnecessary pass statements

5df02b1


          Add type annotations, remove unnecessary pylint disables

8f6c517


          Reformatted per pre-commit

57a5f06

tekktrik requested a review from a team

July 13, 2022 04:21

FoamyGuy approved these changes

View reviewed changes

Contributor

FoamyGuy left a comment

typing additions look good to me. I did not test it.

tekktrik merged commit ca4f5e1 into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@f7cc418)

89c43d4

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#19 from tekktrik/dev/use-protocol-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.19 from 1.1.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#21 from tekktrik/dev/add-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.2.0 from 1.1.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_datetime#20 from tekktrik/fix/fix-dst-error

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.5.3 from 2.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#53 from bablokb/sparkline_opt2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet