save about 400 bytes with _NAMES and a little cleanup #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Jun 2, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 3, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.2.1 from 4.2: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#34 from dhalbert/shrink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shrinks the CPX firmware with frozen LIS3DH by 440 bytes.
I tried a few other things, but they only save a few bytes, like combining multiple assignments to zero into a single assignment, etc. Not worth it for readability.
@tannewt this will allow the latest 3.0 fit in CPX with about 400 bytes to spare.