Update to use int1 for tap detection #19
Conversation
adafruit_lis3dh.py
Outdated
| # Enable ADCs. | ||
| self._write_register_byte(REG_TEMPCFG, 0x80) | ||
| # Initialise interrupt pins | ||
| self._int1 = int1 | ||
| self._int2 = int2 |
There was a problem hiding this comment.
int2 is passed in but never used. Is it there for future-proofing?
There was a problem hiding this comment.
Yes, that was the idea. There is an int2 and in the event a board is designed that uses it, we want the driver to work.
adafruit_lis3dh.py
Outdated
| # Enable ADCs. | ||
| self._write_register_byte(REG_TEMPCFG, 0x80) | ||
| # Initialise interrupt pins | ||
| self._int1 = int1 |
There was a problem hiding this comment.
int1 and int2 are supposed to be DigitalInOut objects that you pass in, but you finish setting up int1's direction and pullup here instead of assuming it's passed in already set up. How about just passing in the pin (e.g. board.D11), not a DigitalInOut? Then the driver can create and manage the DigitalInOut objects itself.
Assuming you do this, change the parameter names to int1_pin and int2_pin.
I'm interested in @tannewt's opinion here too. I do see that in SPIDevice in BusDevice, the chip-select pin is passed in as a DigitalInOut object. So maybe there's a style I'm missing here.
There was a problem hiding this comment.
Passing in the DigitalInOut pin means it could be another compatible object instead. The only requirement we pose is that it provides value, direction and pull. So, this could actually be available through a GPIO expander. Taking the board pin restricts our use to directly connected pins.
There was a problem hiding this comment.
Got it. I though you might want to duck-type something.
|
Updated with @ladyada's changes. Both of us have tested successfully with single-tap, double-tap, on breakout board, and in a CPX CircuitPython test-build with the module frozen. This is ready to go!! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#27 from kattni/tap-detect-update > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#26 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.0.0 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#19 from kattni/int-tapped-update
Includes example of creating
int1object intappeddocumentation.