Added shake detection #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Nov 27, 2017
adafruit_lis3dh/lis3dh.py
Outdated
| anything less than 10 will erroneously report a constant | ||
| shake detected. (Default 30) | ||
| avg_delay - The speed in seconds at which the series of values used for the | ||
| average acceleration are taken. (Default 0.01) |
There was a problem hiding this comment.
I think it'd be clearer if this was total delay. That way its easy to tell how long it will take. Then, in the sleep just divide total delay by the number of samples.
adafruit_lis3dh/lis3dh.py
Outdated
| """ | ||
| shake_accel = (0, 0, 0) | ||
| for i in range(avg_count): | ||
| shake_accel = tuple(map(sum, zip(shake_accel, self.acceleration))) |
There was a problem hiding this comment.
This is pretty tricky. How about adding a comment explaining how it works.
tannewt
requested changes
Nov 27, 2017
| readings from acceleration. (Default 0.1) | ||
| """ | ||
| shake_accel = (0, 0, 0) | ||
| for i in range(avg_count): |
There was a problem hiding this comment.
Please put the internal explanation here after a #. The """ comment should only have the "public" info.
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 1, 2017
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.1.3 from 1.1.2: > Add build tools into the requirements. > Configure Travis builds using circuitpython build tools. > Added import math > Updated neopixels to dostars in doc Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to v1.0.0 from 0.1.3: > Added shake detection (adafruit/Adafruit_CircuitPython_LIS3DH#13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.