-
Notifications
You must be signed in to change notification settings - Fork 45
Volume animation #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume animation #66
Conversation
@kattni, this one is ready for review also. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gamblor21 Hey! We're taking a look at this now. You submitted it before we started using the reuse licensing. Please update the licensing along with any possible suggestions we may have regarding the code.
I would suggest running it through pre-commit to make sure it fits with our current standards.
@gamblor21 This could use an example in the examples directory. I finally managed to make it sort of work after a bit of fiddling. I had this to test, though I never got it to play nicely as the speaker stuttered badly.
|
Just a note that I saw the comments and haven't forgotten about this PR. I hope to have some time soon that I can revisit and update things. Adding an example is a great idea and I can do that as well. |
This same change was in #67 as well. I think it's easiest to just keep it from there and close this one to avoid any merge weirdness. I added an example for the volume animation in a commit over in #67 as well, though I didn't realize there was one in a comment here at the time so it's a little different. closing this one in favor of keeping #67 |
A new animation that takes MP3Decoder volume and adjusts the neopixels both in brightness and number of lit pixels. It could also consume any other object that has a member that reflects the current audio volume.