Add colors for RGBW strips to target the RGB or RGBW LEDs #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhooper
suggested changes
Jul 10, 2020
adafruit_led_animation/color.py
Outdated
| @@ -41,8 +44,10 @@ | |||
| JADE = (0, 255, 40) | |||
| AMBER = (255, 100, 0) | |||
|
|
|||
| RAINBOW = (RED, ORANGE, YELLOW, GREEN, BLUE, PURPLE) | |||
| RGBW_RGB = (255, 255, 255, 0) | |||
| RGBW_RGBW = (255, 255, 255, 255) | |||
There was a problem hiding this comment.
What about RGBW_WHITE_RGB and RGBW_WHITE_RGBW and maybe also RGBW_WHITE_W
There was a problem hiding this comment.
You mean RGB_WHITE_RGB... etc?
There was a problem hiding this comment.
I wasn't sure RGBW_RGB is a clear colour name... This is what I was thinking.
RGBW_WHITE_RGB = (255, 255, 255, 0)
RGBW_WHITE_RGBW = (255, 255, 255, 255)
RGBW_WHITE_W = (0, 0, 0, 255)
There was a problem hiding this comment.
Isn't RGBW_WHITE_* redundant? The W in RGBW is the white diode.
There was a problem hiding this comment.
I see what you're saying, since these are all various permutations of "WHITE" let's call the color WHITE and include which diodes are used to generate the white. Yeah, I like that.
There was a problem hiding this comment.
Updated the PR with the proposed changes.
rhooper
approved these changes
Jul 13, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 14, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.7.10 from 2.7.9: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#69 from kmatch98/bitmap_zero Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.5 from 0.11.4: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#34 from adafruit/readme-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.4.0 from 2.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#61 from georgebohnisch/master > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#60 from rhooper/ring_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for when you want to specifically illuminate the RGB LEDs without the White LEDs or for when you want to go full brightness and turn on all diodes on the chip.