cycle_complete not triggered for Chase animation #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from adafruit master
fix for issue adafruit#56 -- cycle_complete not triggering for Chase animation
rhooper
approved these changes
Jun 27, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 30, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.4 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#11 from kattni/update-combo-example Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 3.3.2 from 3.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#38 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#37 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.3.3 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#21 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#20 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.3.3 from 2.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#58 from cjsieh/cycle_complete > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#49 from nnja/fix_sparkle_and_sparklepulse_animations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anim.draw_count was incremented twice in animation/init.py. This caused the check for cycle_complete to not be triggered in chase.py as it was not expecting a double value . See issue #56