Skip to content

Blink color fix #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Blink color fix #54

merged 2 commits into from
Jun 22, 2020

Conversation

rhooper
Copy link

@rhooper rhooper commented Jun 22, 2020

Fixes a bug where setting .color causes the blink animation to fail. As part of the fix, a small code size for some animations was made, by refactoring the color setter to call _set_color(), which replaces _recompute_color()

@rhooper rhooper requested a review from a team June 22, 2020 23:03
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully.

@kattni kattni merged commit b5e75fa into adafruit:master Jun 22, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants