Add SparklePulse animation #13
Conversation
|
@rhooper - you can also review if you like! |
|
@dmolavi I like the idea of making sparkle able to use pulse animations. Thank you for your contribution! There seems to be a lot of duplication and/or unused code from Sparkle and Pulse that can be cleaned up. I will look closer later today, and suggest the changes needed. |
|
You're more than welcome. This was quick and dirty to get it up and running. I'm more than open to modularizing some of the common code between the animations or whatever other changes should be made. |
|
I should mention an outstanding PR with a whole bunch of changes and improvements that could make the cleanup suggested easier. I just pushed a refactor to that PR that moved the pulse generator to helper.py |
|
@rhooper - I don't want to step on toes, so I haven't pushed this PR any further, esp if you have a refactor and new stuff coming in with your PR. I'm wondering if maybe merging the two PRs into one might be the best solution here? |
|
There's no ETA on the refactor. I will merge this as is and we will do the necessary/requested cleanup at a later date. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.2.1 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#26 from FoamyGuy/ble_patchwork Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#3 from adafruit/update-docs-link Updating https://github.com/adafruit/Adafruit_CircuitPython_HTS221 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_HTS221#3 from adafruit/update-docs-link Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_LIS2MDL#8 from adafruit/update-docs-link Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#8 from adafruit/update-docs-link Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS2X to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_LPS2X#3 from adafruit/update-docs-link Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#13 from dmolavi/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#11 from adafruit/update-docs-link
This new animation is a combo of the Sparkle and Pulse. The effect makes the Pulse work on a single pixel at a time, vs the entire set of pixels.