-
Notifications
You must be signed in to change notification settings - Fork 45
Add more animations, add AggregatePixels helper. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Needs documentation improvements, and testing without pixelbuf (potentially on Raspberry Pi). |
@kattni I don't know how to resolve this error... Some help would be great.
|
…f they were a strip.
@siddacious There is a significant amount of cleanup needed, not including the rebase, before it can be merged. It was waiting on all of the other pixel stuff to be settled which only happened yesterday. Limor asked that I wait to do anything with it until all of that was taken care of, and obviously the situation changed in the meantime. Please leave this open for now. |
…ltiple times to groups, sequences, and animations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the all 3 examples successfully on a Pybadge, a Circuit Playground Bluefruit and a RasPi 3 B+.
led_animation_simpletest.py
works on Metro M0 Express but he other two examples have memory error.
One minor issue on the Rasperry Pi 3 B+ the rainbow_comet
animations was not working on that device for me. No errors or anything, pixels all stayed off during that animation.
One minor suggestion: slow down default speed for the the blink animation in the led_animation_all_animations.py
so it's not flashing so fast out of the gate.
I don't think either are major enough to block merging though.
Thank you Roy and Kattni for working on this very cool library!
Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.0.0 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#21 from kattni/doc-example-update > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#20 from kattni/refactor > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#19 from kattni/update-blink-speed-example > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#10 from rhooper/more-magic
Add more animations, add AggregatePixels helper, add names to animations, add random order, add cycle done callback.