initial code commit #1
Conversation
|
Hi, did you see this also: https://github.com/notro/tmp_CircuitPython_stdlib/blob/master/lib/itertools.py |
|
I hadn't seen that. My goal is just getting itertools (and extensions) workign in CP, where his seems more about the actual porting exercise. |
There was a problem hiding this comment.
@dastels As this code is taken directly from Python, please use the PSF copyright, and update the license to the PSF license. Check the PSF site for the specifics. You may include something like Adapted for CircuitPython by Dave Astels or similar if you wish.
There was a problem hiding this comment.
Looks good. I saw the MicroPython version mentioned in Discord recently and thought it would be a good addition for us. Thanks for getting this done!
Just a few things to remove, since I don't see any reason for this to go up onto PyPI. Part of the standard CPython library, so all of the *nix cases will already have it available, and uPy has its version too.
README.rst
Outdated
| This is easily achieved by downloading | ||
| `the Adafruit library and driver bundle <https://github.com/adafruit/Adafruit_CircuitPython_Bundle>`_. | ||
|
|
||
| Installing from PyPI |
There was a problem hiding this comment.
I would remove the entire Installing from PyPI section, since itertools is available in CPython.
setup.py
Outdated
| @@ -0,0 +1,63 @@ | |||
| """A setuptools based setup module. | |||
There was a problem hiding this comment.
setup.py can be deleted, since itertools is available in CPython and won't need to be deployed to PyPI.
requirements.txt
Outdated
| @@ -0,0 +1 @@ | |||
| Adafruit-Blinka | |||
There was a problem hiding this comment.
Like the other two, Blinka isn't needed since no PyPI.
README.rst
Outdated
| :alt: Discord | ||
|
|
||
| .. image:: https://travis-ci.com/adafruit/Adafruit_CircuitPython_itertools.svg?branch=master | ||
| :target: https://travis-ci.com/adafruit/Adafruit_CircuitPython_itertools |
There was a problem hiding this comment.
The URLs for the Travis badge need to match the repo capitalization.
.. image:: https://travis-ci.com/adafruit/Adafruit_CircuitPython_IterTools.svg?branch=master
:target: https://travis-ci.com/adafruit/Adafruit_CircuitPython_IterTools
|
@sommersoft The MicroPython implementation is extremely minimal.. a few functions. That's the big reason I went back to the "source" material. |
No description provided.