displayio API update #101
displayio API update #101
Conversation
| bits = bits << 1 | ||
| else: | ||
| bits += 8 | ||
| self._bits_per_value = bits |
There was a problem hiding this comment.
This mimics the logic from blinka displayio here: https://github.com/adafruit/Adafruit_Blinka_Displayio/blob/01b274d3a058b8efb7b3c3638511724cbc290a7d/displayio/_bitmap.py#L64-L68
It may ultimately be worth spending a little time to try to update these tests to utilize Blinka Displayio instead of these one-off mocked implementations of core classes anywhere possible.
There was a problem hiding this comment.
Note that the tests failing was unrelated to the primary change in this PR. I believe the root cause of that is bitmaptools being added to Blinka Displayio since the last time these tests were run. The code for this test takes a path that involves using both these mocked Interface class, and the new implementations of bitmaptools which exposed that the Interface was missing this internal field that readinto is relying on.
No description provided.