-
Notifications
You must be signed in to change notification settings - Fork 23
5x5 breakout #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5x5 breakout #41
Conversation
sync with origin
Module structure copied over from keybow2040.py Translation table from https://github.com/pimoroni/rgbmatrix5x5-python/blob/master/library/rgbmatrix5x5/is31fl3731.py
Based on the Keybow2040 rainbow demo by Sandy Macdonald Totally untested...
To make it more easy to troubleshoot, the code goes red, then green, then blue... and only then goes rainbow.
Add link to example RGB Matrix 5x5 and merging color example. Still missing the Keybow2040.
Ok, and pylint believe there is duplicate code because Keybow 2040 use a very similar lookup table (even if it only contain 16 entries and at least 4 entries do not exist in led-shim/matrix5x5 table. |
This code is duplicate with the first entry in Keybow2040 lookup by Pimoroni design. The lookup could be replaced by a function like in led-shim as led-shim and matrix 5x5 use the same table.
I think the duplication is coming from |
@dglaude :) would you be able to work on this? thanks |
Unfortunately, the current If I have time this weekend I'll try to work out the correct values. |
Hi @dglaude. I believe I've got this working correctly and passing pre-commit: If you can give me write permission to this branch, I push a commit with the changes. |
Superseded by #45 |
This is not tested on the real hardware, so it has to be considered draft until this is tested.
Room for improvement:
Adafruit_CircuitPython_IS31FL3731/adafruit_is31fl3731/led_shim.py
Line 63 in 11533d4