Skip to content

5x5 breakout #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

5x5 breakout #41

wants to merge 8 commits into from

Conversation

dglaude
Copy link
Contributor

@dglaude dglaude commented Mar 15, 2021

This is not tested on the real hardware, so it has to be considered draft until this is tested.

Room for improvement:

dglaude added 7 commits March 10, 2021 01:15
Based on the Keybow2040 rainbow demo by Sandy Macdonald
Totally untested...
To make it more easy to troubleshoot, the code goes red, then green, then blue... and only then goes rainbow.
Add link to example RGB Matrix 5x5 and merging color example.
Still missing the Keybow2040.
@dglaude dglaude marked this pull request as draft March 15, 2021 00:33
@dglaude dglaude changed the title 5x5 breakout (draft) 5x5 breakout Mar 15, 2021
@dglaude
Copy link
Contributor Author

dglaude commented Mar 15, 2021

Ok, and pylint believe there is duplicate code because Keybow 2040 use a very similar lookup table (even if it only contain 16 entries and at least 4 entries do not exist in led-shim/matrix5x5 table.

This code is duplicate with the first entry in Keybow2040 lookup by Pimoroni design.
The lookup could be replaced by a function like in led-shim as led-shim and matrix 5x5 use the same table.
@tannewt tannewt requested a review from a team March 15, 2021 23:10
@tannewt
Copy link
Member

tannewt commented Mar 16, 2021

Ok, and pylint believe there is duplicate code because Keybow 2040 use a very similar lookup table (even if it only contain 16 entries and at least 4 entries do not exist in led-shim/matrix5x5 table.

I think the duplication is coming from pixelrgb instead of the lookup. I think you can create a parent class for 5x5 and keybow that adds pixelrgb for both.

@jposada202020
Copy link

@dglaude :) would you be able to work on this? thanks

@evaherrada evaherrada changed the base branch from master to main June 7, 2021 17:12
@lesamouraipourpre
Copy link
Contributor

Unfortunately, the current pixel_addr doesn't work for this led matrix. (Video below)
The test code is slightly modified from the example to repeat endlessly.
https://user-images.githubusercontent.com/70200140/121439010-f6486780-c97c-11eb-8339-a846aa2dbc24.mp4

If I have time this weekend I'll try to work out the correct values.

@lesamouraipourpre
Copy link
Contributor

Hi @dglaude.

I believe I've got this working correctly and passing pre-commit:
https://user-images.githubusercontent.com/70200140/121524981-c6867780-c9ef-11eb-9e24-695349321be2.mp4

If you can give me write permission to this branch, I push a commit with the changes.

@tannewt
Copy link
Member

tannewt commented Jun 22, 2021

Superseded by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants