Purple was showing up as blue, so I fixed it #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Aug 2, 2019
deshipu
reviewed
Aug 2, 2019
| @@ -36,7 +36,7 @@ | |||
| # Draw a smaller inner rectangle | |||
| inner_bitmap = displayio.Bitmap(280, 200, 1) | |||
| inner_palette = displayio.Palette(1) | |||
| inner_palette[0] = 0x65328F # Blinka Purple | |||
| inner_palette[0] = 0xAA0088 # Purple | |||
There was a problem hiding this comment.
Are you sure this is not another case of the RGB/BGR mixup?
There was a problem hiding this comment.
Yes. Red is red, blue is blue. It's more of a RGB888->RGB565 issue.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 2, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#11 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#10 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#9 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to v1.1.0 from v1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#7 from brentru/refactor_req > Merge pull request adafruit/Adafruit_CircuitPython_Requests#5 from brentru/add-parse-headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.