-
Notifications
You must be signed in to change notification settings - Fork 10
Fixed issue with passing inverted bits keyword arguments #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tannewt i just noticed that if swap_rams is true that color_bits_inverted / black_bits_inverted are referring to the wrong keyword args. I will add a fix for that too. |
I think that's on purpose because they're being swapped. |
I thought the swap was referring to the actual commands and not to the inverted option. |
Let's see what @tannewt says. |
Thanks for the fix! I agree that swapping black and color ram args with swap_rams is the right approach. The two examples that use swap_rams don't set either so it is safe to change. Would you mind adding parameter comments into the class comment? I should have done it when I added the driver. |
@tannewt I added documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc! One question about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, great! Would you mind filing an issue on CircuitPython to support R? It should be easy to add.
Updating https://github.com/adafruit/Adafruit_CircuitPython_74HC595 to 1.0.4 from 1.0.3: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_74HC595#7 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.0.2 from 1.0.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#6 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#5 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 1.2.6 from 1.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#15 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_AS726x to 1.0.5 from 1.0.4: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_AS726x#9 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_AS726x#7 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.1.3 from 1.1.2: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#12 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#11 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.2.5 from 3.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#30 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_DHT#26 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305 to 1.0.4 from 1.0.3: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305#6 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_DS18X20 to 1.2.2 from 1.2.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_DS18X20#16 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_DS2413 to 1.1.6 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#15 from adafruit/dherrada-patch-2 > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#13 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3502 to 1.0.3 from 1.0.2: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_DS3502#2 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_DS3502#1 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_HCSR04 to 0.3.5 from 0.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#14 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#11 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#10 from dhalbert/fix-image > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#9 from junhe/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20649 to 1.0.2 from 1.0.1: > update pylint examples directive Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.1.1 from 1.1.0: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#7 from bmeisels/kwargs_fix > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#6 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#5 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0398 to 1.0.1 from 1.0.0: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_IL0398#4 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_IL0398#3 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.0.1 from 1.0.0: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#4 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#3 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#2 from adafruit/TheKitty-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.4.1 from 3.4.0: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#29 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#28 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#15 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#14 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LIDARLite to 1.1.3 from 1.1.2: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_LIDARLite#8 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_LIDARLite#7 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.0.1 from 2.0.0: > update pylint examples directive Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX9744 to 1.1.3 from 1.1.2: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#9 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#8 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90614 to 1.1.3 from 1.1.2: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_MLX90614#14 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MLX90614#13 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL115A2 to 1.0.3 from 1.0.2: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_MPL115A2#5 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MPL115A2#4 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 5.0.0 from 4.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#70 from adafruit/revert-59-pixelbuf Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.1.2 from 1.1.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#5 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.0.1 from 1.0.0: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#4 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#3 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_STMPE610 to 1.1.4 from 1.1.3: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#10 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#9 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermal_Printer to 1.1.4 from 1.1.3: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#12 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#11 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC59711 to 1.1.4 from 1.1.3: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#9 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#7 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP006 to 2.0.1 from 2.0.0: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_TMP006#8 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_TMP006#6 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_TPA2016 to 1.0.2 from 1.0.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_TPA2016#4 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_TPA2016#3 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_US100 to 1.0.5 from 1.0.4: > update pylint examples directive Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.9.5 from 0.9.4: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#8 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#7 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4040 to 1.1.1 from 1.1.0: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4040#6 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4040#5 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.0.2 from 3.0.1: > update pylint examples directive Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6075 to 1.0.4 from 1.0.3: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_VEML6075#8 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_VEML6075#7 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 1.2.1 from 1.2.0: > update pylint examples directive Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#29 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#28 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.0.5 from 1.0.4: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#6 from SeattleChris/example_test Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.0.2 from 1.0.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#7 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#5 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#6 from vkhalaim/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.1.2 from 4.1.1: > update pylint examples directive Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.1.4 from 2.1.3: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#15 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#14 from brentru/add-pypi > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#13 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 1.1.4 from 1.1.3: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#9 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.1.2 from 1.1.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#9 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 4.0.1 from 4.0.0: > update pylint examples directive Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 1.0.2 from 1.0.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_Hue#6 from brentru/add-deps-to-readme > Merge pull request adafruit/Adafruit_CircuitPython_Hue#10 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Hue#9 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 1.0.2 from 1.0.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#6 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#5 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#11 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.0.2 from 1.0.1: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#6 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#5 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.1.6 from 0.1.5: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#14 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#13 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 1.1.7 from 1.1.6: > update pylint examples directive > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#18 from brentru/pypi-setup Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_DisplayIO_SSD1305, Adafruit_CircuitPython_IL0373, Adafruit_CircuitPython_IL0398, Adafruit_CircuitPython_IL91874, Adafruit_CircuitPython_SSD1325, Adafruit_CircuitPython_SSD1675, Adafruit_CircuitPython_AdafruitIO, Adafruit_CircuitPython_BitmapSaver, Adafruit_CircuitPython_CursorControl, Adafruit_CircuitPython_Gizmo, Adafruit_CircuitPython_MiniMQTT
When a user passes in black_bits_inverted or color_bits_inverted the IL0373 initializer will pass the keyword argument twice to the displayio.EPaperDisplay initializer rwhich raises an exception ('TypeError: extra keyword arguments given').
The fix is to swap dict.get for dict.pop