-
Notifications
You must be signed in to change notification settings - Fork 28
Removed artifical limiting of 7x4 display (LOL) #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I needed more LOL'ing in my life, and a 7x4 segment display can help with this. However, adafruit_ht16k33 filters this out for the 7x4 display which makes me super sad 😢. This change allows the use of both upper and lower case L's and O's. (also, matrix.py and segments.py had the eXecutable bit set, which has been dropped) Fixes: adafruit#79 Signed-off-by: Dave Walker (Daviey) <[email protected]>
I wonder what is your use case for this? If you need to display arbitrary patterns, then just use a lower-level interface. |
I wanted to use |
Sounds like a good idea: either extending the marquee to work with arbitrary patterns, or writing a version that does strikes me as a cleaner and more general solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created #94 to open up the idea of extending marquee to work with set digits raw.
I also merged main into this PR branch to get it passing the CI.
Tested the changes successfully with RP2040 and 7x4 featherwing.
I think it's okay to merge it this way for now. If in the future someone makes a more general way to place other text characters or arbitrary patterns into the marquee then we can remove the code specific to l
and o
here.
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.1.8 from 4.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#80 from Daviey/moar_lolz > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 3.1.8 from 3.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#28 from adafruit/dhalbert-ustruct > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.2.10 from 1.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#24 from adafruit/dhalbert-ustruct > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.11.0 from 0.10.7: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#23 from tekktrik/feature/add-sound-level > Merge pull request adafruit/Adafruit_CircuitPython_BLE_BroadcastNet#22 from tekktrik/feature/add-typing > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.2.0 from 1.1.10: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#33 from TonyLHansen/main > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_BoardTest to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#19 from tekktrik/feature/add-typing > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.5.1 from 2.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#30 from tekktrik/feature/add-typing > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to 1.4.0 from 1.3.6: > Update README.rst > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#17 from timhawes/main > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.3.3 from 3.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#59 from FoamyGuy/typing_input_error_catch Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.9.7 from 1.9.6: > Merge pull request adafruit/Adafruit_CircuitPython_Register#46 from adafruit/dhalbert-ustruct > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.10.3 from 1.10.2: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#87 from tekktrik/main > update rtd py version
I needed more LOL'ing in my life, and a 7x4 segment display can help
with this.
However, adafruit_ht16k33 filters this out for the 7x4 display which
makes me super sad 😢. This change allows the use of both upper and
lower case L's and O's.
(also, matrix.py and segments.py had the eXecutable bit set, which has
been dropped)
Fixes: #79
Signed-off-by: Dave Walker (Daviey) [email protected]