Skip to content

Modified the brightness property to use floats instead of ints, and #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Modified the brightness property to use floats instead of ints, and #65

wants to merge 3 commits into from

Conversation

geekguy-wy
Copy link

changed the animation demo to use it.

@FoamyGuy
Copy link
Contributor

I do like using the floats to be consistent with RGB LEDs and display brightness. But I worry about any existing code using 0-15 breaking with this change.

Is it worth it to handle both ways? i.e. if user passes a number < 1 it will use it as a float, but if its >1 it will use the old 0-15 way?

Or is it better to just go ahead and "rip the bandaid" all at once with the breaking change?

@geekguy-wy
Copy link
Author

I do like using the floats to be consistent with RGB LEDs and display brightness. But I worry about any existing code using 0-15 breaking with this change.

Is it worth it to handle both ways? i.e. if user passes a number < 1 it will use it as a float, but if its >1 it will use the old 0-15 way?

Or is it better to just go ahead and "rip the bandaid" all at once with the breaking change?

I could do this, but I think many users will not change to using floats unless they absolutely have to.

@makermelissa
Copy link
Collaborator

Closing this PR since it is a duplicate of #70. In the future, it is recommended to use 2 different branches for different PRs as updating the branch will change code on any existing PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants