-
Notifications
You must be signed in to change notification settings - Fork 28
Add support for 1.2" 4-Digit 7-Segment Displays #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1009122
added AM/PM indicator control
8fe0f4c
added colon control, maybe wacky?
d1e7c17
added AM/PM indicator control
df0b5bc
added colon control, maybe wacky?
e7e452d
refined
8adfaee
merged in master updates
debd029
remove stubbed out func, typos
30ba1db
sir lint-a-lot
5d25dc3
it's ok linty, it's a friendly class
aff4185
change and move pylint disable
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding the
# pylint: enable=your-lint-complaint
wherever it needs to be in the event that something is eventually added to the end of this file. I'm not certain where it needs to go - it may need to encompass the entire class, or it may be able to go on line 205. Please experiment to find the best location for it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to inside the class. The disables apparently work at a code block level, so I think this should limit to with the class itself.