Update RMC parsing to handle the extra parameter in NMEA 4.1 #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sure. I'll try to make it soon.
The module that I've got the issue onto is Quectel L76K |
|
Yes. I confirm that this PR works fine both in NMEA 4.0 and 4.1 modes. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 14, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.9.1 from 3.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#66 from lesamouraipourpre/rmc > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > Merge pull request adafruit/Adafruit_CircuitPython_GPS#59 from lesamouraipourpre/pylint-yaml Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.12.1 from 2.12.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#67 from eliotg/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.15.2 from 1.15.1: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#55 from deshipu/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should update the parsing to handle the extra parameter. (Closes #65)
This has NOT been tested as my GPS modules are at another location. (I can get them later in the week if needed)
@lyusupov Are you able to test the pull request against your hardware?
Out of interest, what device/module are you using that is sending NMEA 4.1+ sentences?
Also, a minor correction to simpletest