-
Notifications
You must be signed in to change notification settings - Fork 60
feat(raw): Adding raw sentence #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,6 +115,7 @@ def __init__(self, uart, debug=False): | |
self.total_mess_num = None | ||
self.mess_num = None | ||
self.debug = debug | ||
self.raw_sentence = None | ||
|
||
def update(self): | ||
"""Check for updated data from the GPS module and process it | ||
|
@@ -175,7 +176,12 @@ def datetime(self): | |
"""Return struct_time object to feed rtc.set_time_source() function""" | ||
return self.timestamp_utc | ||
|
||
def _parse_sentence(self): | ||
@property | ||
def raw_sentence(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename to nmea_sentence |
||
"""Return raw_sentence which is the raw NMEA sentence read from the GPS""" | ||
return self.raw_sentence | ||
|
||
def _read_sentence(self): | ||
# Parse any NMEA sentence that is available. | ||
# pylint: disable=len-as-condition | ||
# This needs to be refactored when it can be tested. | ||
|
@@ -200,8 +206,23 @@ def _parse_sentence(self): | |
actual ^= ord(sentence[i]) | ||
if actual != expected: | ||
return None # Failed to validate checksum. | ||
# Remove checksum once validated. | ||
sentence = sentence[:-3] | ||
|
||
# copy the raw sentence | ||
self.raw_sentence = sentence | ||
|
||
return sentence | ||
# At this point we don't have a valid sentence | ||
return None | ||
|
||
def _parse_sentence(self): | ||
sentence = self._read_sentence() | ||
|
||
# sentence is a valid NMEA with a valid checksum | ||
if sentence is None: | ||
return None | ||
|
||
# Remove checksum once validated. | ||
sentence = sentence[:-3] | ||
# Parse out the type of sentence (first string after $ up to comma) | ||
# and then grab the rest as data within the sentence. | ||
delimiter = sentence.find(',') | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call this _raw_sentence (private)