Skip to content

Added support for GPGLL, GPVTG, GPGSA, and GPGSV NMEA sentences #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
May 15, 2019
Merged

Added support for GPGLL, GPVTG, GPGSA, and GPGSV NMEA sentences #27

merged 22 commits into from
May 15, 2019

Conversation

evaherrada
Copy link
Collaborator

I tested this on a feather M4 with the Ultimate GPS FeatherWing and, to the best of my knowledge, it works.

evaherrada and others added 19 commits May 9, 2019 09:37
@evaherrada
Added support for GPGSV. Haven't tested yet
213c36b
@evaherrada
Modified version of simpletest to allow me to test different formats
a4f0525
@evaherrada
Have to commit this before I switch branch
ec5ddbe
@evaherrada
Commented out some code that made self.has_fix a variable
e2d8b83
@evaherrada
Removed tester.py
358d7d5
@evaherrada
Added all functions. They still need testing
e52d879
@evaherrada
Merge pull request #3 from adafruit/master
91e1ddf 
Merging
@evaherrada
Merge pull request #4 from dherrada/master
975fdd8 
Merging
@evaherrada
Pretty much where I was last commit lol
f5376ae
@evaherrada
Added function to parse GPGLL data. It FINALLY works
9d4beb8
@evaherrada
Reverted simpletest
b5c5752
@evaherrada
Added explanation for commenting out block that checked if in_waiting…
5e26243 
… was 64 bytes
@evaherrada
Reverted .gitignore to earlier version
74c50a5
@evaherrada
Changed delineator to delimiter
77325a6
@evaherrada
Fixed _parse_gpgsa
a6fd9c2
@evaherrada
self.sats is now defined in __init__
9cd3257
@evaherrada
Finished all functions for parsing sentences. It finally works
c67fb4c
@evaherrada
Made (mostly) pep8 compliant
50161af
@evaherrada
Removed redundant code
724eec8
@evaherrada
Copy link
Collaborator Author

I also think it would be worth looking at making a page in the docs or in the learning guide with the sole purpose of explaining NMEA and the different sentences. It was really confusing to me for the first few hours, and I imagine it could be to anyone else who wants to dive deeper than the basic sentences (GGA and RMC).

kattni
kattni approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I did not test this one - @dherrada tested it successfully.

@kattni kattni merged commit 1960c04 into adafruit:master May 15, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 16, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@179741a)
ad97b15 
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.3.0 from 3.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#29 from dherrada/format-adding
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#27 from dherrada/format-adding
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#28 from dherrada/bug-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evaherrada @kattni