Skip to content

_parse_sentence may fail with an UnicodeError after a soft reboot #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MSube opened this issue Apr 10, 2019 · 1 comment
Closed

_parse_sentence may fail with an UnicodeError after a soft reboot #19

MSube opened this issue Apr 10, 2019 · 1 comment

Comments

@MSube
Copy link

MSube commented Apr 10, 2019

Auto-reload is on. Simply save files over USB to run them or enter REPL to disable.
code.py output:
Traceback (most recent call last):
File "code.py", line 7, in
File "adafruit_gps.py", line 102, in update
File "adafruit_gps.py", line 148, in _parse_sentence
UnicodeError:

line 148: sentence = str(sentence, 'ascii').strip()
fails if sentence contains stale data that is not ascii.
@evaherrada evaherrada mentioned this issue May 8, 2019
Merged
tannewt added a commit that referenced this issue May 9, 2019
@tannewt
Merge pull request #21 from dherrada/master
0e0b152 
Fixed an issue mentioned in issue #19 where a UnicodeError would be raised when there was noise over UART
@evaherrada
Copy link
Collaborator

Can you check and see if this still happens? #21 should have fixed this

@deshipu deshipu closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deshipu @MSube @evaherrada