code format and pylint fixes #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 20, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 3.1.1 from 3.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#21 from FoamyGuy/fix_format > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#20 from geudrik/fix_ntp_requirement > Fixed readthedocs build > Post-patch cleanup > Consolidate Documentation sections of README > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 2.2.4 from 2.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_turtle#25 from lesamouraipourpre/ondiskbitmap-changes > Fixed readthedocs build > Consolidate Documentation sections of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20 was showing passed CI before merging. But it seems there were differences between the current black and pylint checks.
This change gets the repo back to passing everything in pre-commit. It needed black formatting, removing
ffrom a string not used for formatting, splitting a long line, and adding ignore comment for imports outside of top of file. NTP import was moved outside of the top level specifically for #20 to support devices that don't have it.