-
Notifications
You must be signed in to change notification settings - Fork 12
Adding documentation for dotstars
attribute.
#30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for submitting this. It looks like the error is not in this library, but in adafruit_requests:
|
Looks like the failure is related to issue adafruit/Adafruit_CircuitPython_Requests#93. I'd like to wait for it to be fixed before we merge this in, so we can re-run and have it pass cleanly. |
This keeps installing Adafruit_CircuitPython_Requests 1.10.4 which has the bug and is not updating to 1.10.5. I am going to close this and re-open in an attempt to have it update. |
I forced it to install the latest version by specifying it in the dependencies, but it refuses to work:
I can run it locally on my computer, so it seems to cache older versions of the available dependencies. I'll have to circle back to this later. Maybe by then the cache will have expired and it will have an update. |
I think that may be due to the 1.10.5 version of adafruit_requests now requiring Python 3.8 while this library's CI is setup to use Python 3.7, so pip doesn't consider the 1.10.5 version of adafruit_requests as a candidate for installation under Python 3.7. |
Thank you. That's a good theory and makes sense. |
It appears the remote repository is not allowing me to push changes anymore, so I'm closing and will open my own PR. |
I couldn't figure out how the API docs were generated and sent to https://circuitpython.readthedocs.io/projects/funhouse/en/latest/api.html#adafruit-funhouse-peripherals and so I've not been able to test this formats OK.
If someone could give me a pointer on how to run a test build of the API doc, I'd be happy to give it a test.