Skip to content

Place the MQTT Loop in a try/except block #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2021
Merged

Place the MQTT Loop in a try/except block #3

merged 3 commits into from
Apr 7, 2021

Conversation

makermelissa
Copy link
Collaborator

This is to solve an issue that both @jedgarpark and I ran into when running this overnight:

Traceback (most recent call last):
  File "code.py", line 65, in <module>
  File "adafruit_io/adafruit_io.py", line 215, in loop
  File "adafruit_minimqtt/adafruit_minimqtt.py", line 782, in loop
  File "adafruit_minimqtt/adafruit_minimqtt.py", line 552, in ping
MMQTTException: PINGRESP not returned from broker.

@makermelissa makermelissa requested a review from a team April 7, 2021 15:35
dhalbert
dhalbert requested changes Apr 7, 2021
View reviewed changes
@brentru
Copy link
Member

brentru commented Apr 7, 2021 •
edited
Loading

@makermelissa I didn't get to initially review but just looked thru this...
return self.init_mqtt(IO_MQTT_BROKER, 1883, aio_username, aio_key, True)

May want to use secure port 8883. Setting up the client for the S2/SSL will be different and may need to be modified. I can take out another issue.

@makermelissa makermelissa requested a review from dhalbert April 7, 2021 16:07
dhalbert
dhalbert approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 though do see @brentru's comment.

@makermelissa
Copy link
Collaborator Author

@brentru let's do a new issue for that.

@makermelissa makermelissa merged commit c9bdaad into adafruit:main Apr 7, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 9, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
546c6b0 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.6 from 5.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#76 from ViennaMike/fix_fusion_modes
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.3.5 from 2.3.4:
  > Moved a function around
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#28 from jimbobbennett/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.4.0 from 1.3.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#42 from FoamyGuy/add_forkawesome_example
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Heart_Rate to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Heart_Rate#13 from adafruit/tannewt-patch-1
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_iBBQ to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_iBBQ#5 from adafruit/tannewt-patch-1
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_MIDI to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_MIDI#7 from adafruit/tannewt-patch-1
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.3.11 from 1.3.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#27 from adafruit/linting
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.9.1 from 1.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#33 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.14.2 from 1.14.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#71 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 1.1.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#6 from makermelissa/main
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#5 from makermelissa/main
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#3 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 4.3.0 from 4.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#63 from JPEWdev/consumer-press-release

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.2.2 from 2.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#71 from makermelissa/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.3.5 from 1.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#32 from jepler/update-simpletest

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.4.0 from 0.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#20 from adafruit/jepler-frequency-too-low
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#17 from gamblor21/mov_operators

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.9.9 from 1.9.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#76 from askpatrickw/fix-48
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@makermelissa @brentru @ladyada @dhalbert