Pylint and RTD update patch, and other fixes #23
Conversation
requirements.txt
Outdated
| @@ -12,3 +12,4 @@ adafruit-circuitpython-simpleio | |||
| adafruit-circuitpython-minimqtt | |||
| adafruit-circuitpython-dps310 | |||
| adafruit-circuitpython-ahtx0 | |||
| sphinx>=4.0.0 | |||
There was a problem hiding this comment.
This needs to go into a new /docs/requirements.txt file, not in the /requirements.txt file. Please create the new file, add this to it, and remove it from here.
There was a problem hiding this comment.
@tekktrik I just realised you did it on all your PRs. I didn't notice it until now. Please go back through and submit another PR to fix this issue. Apologies for not being clearer about it in the beginning.
There was a problem hiding this comment.
Yeah, thank you for catching that, I'll go make those changes now
There was a problem hiding this comment.
@tekktrik I think this line still needs to be removed - unless the diff is acting up.
|
Okay, fixed the issue and submitted additional PRs for those repos that got approved. Any that you haven't touched should also have the appropriate commit for this. Thanks for catching it! |
|
Got it, I'll check tonight an either change it or re-request the review if the diff is in fact acting up! |
|
Yup, it was still there, just removed it! |
No description provided.