Skip to content

Fix download image, character file, and template to the sensor. Edited on the _send_data function. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

ajiekurniawansaputra
Copy link
Contributor

@ajiekurniawansaputra ajiekurniawansaputra commented Mar 9, 2022

Add checksum for the _ENDDATAPACKET on the _send_data function, the previous version only concatenate _DATAPACKET checksum which result in error when downloading image, character file, and template to the sensor.

This fix resolve issue #39 and #41.

Thank you.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up checking the datasheet, and this lines up with that. Also wouldn't alter any other existing behavior otherwise. Thanks for the fix!

@tekktrik tekktrik merged commit ef85cc5 into adafruit:main Mar 24, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 26, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.2.0 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#60 from dhalbert/no-pypixelbuf

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 4.2.0 from 4.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#161 from anecdata/getRemoteData

Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 2.2.4 from 2.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#47 from ajiekurniawansaputra/main
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.3.0 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#16 from dhalbert/no-pypixelbuf

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.3.0 from 6.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#124 from dhalbert/no-pypixelbuf
  > Fixed readthedocs build

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel_SPI to 1.0.0 from 0.9.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel_SPI#33 from dhalbert/pixelbuf-only
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.6.2 from 5.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#84 from adafruit/fix_isconnected
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_Pixelbuf to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Pixelbuf#5 from tekktrik/doc/fix-lib-name
  > Fixed readthedocs build
  > Post-patch cleanup
  > Consolidate Documentation sections of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

struct.error: unpack requires a buffer of 2 bytes Can't template file compare with SEN0188
2 participants