Skip to content

library expansion and compatibility with other ZhianTec fp sensors #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Feb 5, 2020
Merged

library expansion and compatibility with other ZhianTec fp sensors #11

merged 23 commits into from
Feb 5, 2020

Conversation

stitchesnburns
Copy link
Contributor

@stitchesnburns stitchesnburns commented Feb 12, 2019 •
edited
Loading

this should address compatibility for other models of the same brand (ZhianTec) of fingerprint sensors, particularly models with higher memory capacity. tested on a same-brand fingerprint sensor with 1000 template memory.

also, expanded the library by implementing methods such as read_sysparam(), get_fpdata(), send_fpdata(), empty_library(), as well as sending and receiving data payload. fingerprint templates and images may now be downloaded/uploaded. special note on the uploading/downloading of fingerprint images, data stream should not be taken as is and must be manipulated as stated in the manual (4.2.1).

@stitchesnburns
hack for other compatible fp sensors
b7639f9 
dirty hack for compatible fingerprint sensors with capacity greater than the default, since the function limits reading the templates to 162(?).  an observation: each pass reads 256 templates (0-255) so for sensors with 1000 templates, 4 passes are required.  but there must be a better way to do this.  tested on this hardware: https://circuit-help.com.ph/product/fingerprint-sensor-2/
@stitchesnburns
added reset library functionality
358c49a
@stitchesnburns
Merge pull request #2 from stitchesnburns/stitchesnburns-patch-2
9e3722e 
added additional functionalities
@stitchesnburns
fixed travis build failure
3ef2398
@stitchesnburns
created an empty_lilbrary() function
c874c42
@stitchesnburns
created an empty_library() function
c17ed41
@stitchesnburns
Update adafruit_fingerprint.py
98cd938
@stitchesnburns
Update fingerprint_simpletest.py
a04f55f
@stitchesnburns
Update fingerprint_simpletest.py
2a94c93
@kattni kattni mentioned this pull request Feb 18, 2019
Open
@stitchesnburns stitchesnburns changed the title hack for compatible fp sensors library expansion and compatibility with other ZhianTec fp sensors Apr 5, 2019
@kattni kattni requested a review from a team January 8, 2020 14:27
ladyada
ladyada requested changes Jan 8, 2020
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make a new example as you like - dont change the default one

@stitchesnburns
Copy link
Contributor Author

copy that. will be creating a new example based on the default one. will also rebase/update forked repo.

@stitchesnburns
Copy link
Contributor Author

added saving the fingerprint image to a file in the example in response to @mhsattarian's issue. note that the fingerprint module is connected to RPi via GPIO. connection via USB is not tested.

@mhsattarian
Copy link

Thanks a lot for this. I tested using CH340G USB to TTL converter and was able to get the image and save it using OpenCV. I'll test your code today, it should work perfectly.

@mhsattarian
Copy link

Hi, I just tested your code using the CH340G USB to TTL converter and it worked easily.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Feb 5, 2020

I don't have access to the other sensors that this is adding support for. But I have tested these changes with https://www.adafruit.com/product/751 Using the simpletest code: enrolling, finding, and deleting fingerprints is working as expected using the patched library.

@kattni
Copy link
Contributor

kattni commented Feb 5, 2020

@FoamyGuy Excellent, thank you! Please feel free to merge this PR.

@FoamyGuy FoamyGuy merged commit e68d121 into adafruit:master Feb 5, 2020
@mhsattarian
Copy link

mhsattarian commented Feb 8, 2020 •
edited
Loading

I don't have access to the other sensors that this is adding support for. But I have tested these changes with adafruit.com/product/751 Using the simpletest code: enrolling, finding, and deleting fingerprints is working as expected using the patched library.

I had checked using the R301T sensor. I know it's not from Adafruit, just wanted to let you know.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Feb 9, 2020

@mhsattarian Thank you for the link.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 18, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a5464f8)
b4a843a 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#52 from ares-est/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.0.3 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#17 from kattni/slideshow-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#14 from dherrada/master
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#16 from kattni/slideshow-example
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#15 from kattni/add-display-object
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#12 from kattni/add-space
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#11 from kattni/variable-change
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#10 from kattni/level-bubble-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#9 from kattni/color-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#8 from kattni/example-update

Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#11 from stitchesnburns/stitchesnburns-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.0.2 from 2.0.1:
  > Update README.rst

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#5 from BiffoBear/rename-example-file
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#4 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#5 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.2.3 from 2.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#21 from foozmeat/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#5 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.10 from 3.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#65 from cogliano/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.8.9 from 3.8.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#70 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.11 from 1.0.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#17 from caternuson/controller_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.2.0 from 4.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#43 from dhalbert/avoid-alloc

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#10 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_LPS2X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stitchesnburns @mhsattarian @FoamyGuy @kattni @ladyada