Skip to content

import typing / import ustruct #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FlamyEdge opened this issue Dec 3, 2021 · 1 comment
Closed

import typing / import ustruct #36

FlamyEdge opened this issue Dec 3, 2021 · 1 comment

Comments

@FlamyEdge
Copy link

I'm using a Metro M0 express with Circuitpython 7.0.0 and when I try to run a simple code with import adafruit_fingerprint I get a ImportError: no module named 'ustruct'. While checking the code I saw that the fingerrprint lib try to import ustruct only if typing, busio or struct isn't present. By checking the default module of Circuitpython 7.0.0 I can confirm the absence of typing and ustruct.
Am I missing something?
jepler added a commit that referenced this issue Dec 3, 2021
@jepler
separate typing imports try/except from sturct import try/except
1c56c2c 
The changes to add type hints accidentally made the module
non-importable on circuitpython boards.

I'm not sure whether we need to keep the `ustruct` compatibility
(it would only apply to micropython) but go ahead and do so.

Closes: #36
@jepler jepler mentioned this issue Dec 3, 2021
Closed
@dhalbert
Copy link
Contributor

Fixed by #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dhalbert @FlamyEdge