Skip to content

Update minitft_featherwing.py #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 13, 2019
Merged

Conversation

hexthat
Copy link
Contributor

@hexthat hexthat commented Apr 13, 2019

Set the SPI speed, I was having some issues with it being way to slow.

@jerryneedell
Copy link
Contributor

jerryneedell commented Apr 13, 2019

@hexthat I don't know if you see the errors from the travis pylint but it wants you to fix the spacing on some continuation lines

************* Module adafruit_featherwing.minitft_featherwing
C: 84, 0: Wrong continued indentation (add 1 space).
                                        command=board.D6,
                                        ^| (bad-continuation)
C: 85, 0: Wrong continued indentation (add 1 space).
                                        chip_select=board.D5)
                                        ^| (bad-continuation)
C: 87, 0: Wrong continued indentation (remove 8 spaces).
                                       rotation=270, bgr=True)
                               |       ^ (bad-continuation)

@hexthat
Copy link
Contributor Author

hexthat commented Apr 13, 2019

okay i fixed that line to what it was

hexthat added 3 commits April 13, 2019 14:58
>.< dont look idk what im doing
button mask after display, no clue why
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works great. Fixes #40 as well.

@makermelissa makermelissa merged commit 781b4ef into adafruit:master Apr 13, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants