Skip to content

Added GPS FeatherWing #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2019
Merged

Added GPS FeatherWing #28

merged 2 commits into from
Feb 23, 2019

Conversation

makermelissa
Copy link
Collaborator

Ok, here's the GPS FeatherWing code. It handles the initialization automatically, makes some properties shorter names and has some speed calculations such as providing the speed in MPH and KPH.

@makermelissa makermelissa requested a review from a team February 23, 2019 03:08
@makermelissa
Copy link
Collaborator Author

Also, I have tested this on the Feather M4 Express and the Feather nRF52840 Express.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor cosmetic suggestion.


def update(self):
"""
Make sure to call gps.update() every loop iteration and at least twice
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wan it to show up as code in the docs, you can put double backticks on either side (``). Single backticks will cause sphinx to attempt to do something with it, double tells sphinx that you're trying to display something in fixed-width font.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm referring to gps.update().

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't know that.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@kattni kattni merged commit 44eb33e into adafruit:master Feb 23, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 24, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#3 from ladyada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.7.1 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#31 from jerryneedell/jerryn_gps
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#29 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#28 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_PyPortal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants