-
Notifications
You must be signed in to change notification settings - Fork 12
Added 7-Segment FeatherWing #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmmm -- just a heads up -- I tried thsi on a Particle Argon and it causes the board to reset ?? |
Uh oh. I don't have any particle boards to test this out on. :-\ |
Could you also check the AlphaNumeric FeatherWing if you have it Jerry? The code bases are pretty much the same. |
no idea why it should matter -- do you have any nrf52840 boards? |
Nope. |
works fine on a feather_m4_express.. I'll try a different nrf52840 |
fails the same way on a feather_nrf52840_express -- very strange |
I'll try the 14 segment |
same result with alphanum |
Yeah, I developed it against a Feather M4 Express and I think I tried it out on the Feather M0 as well. |
let me try previous release of alphanum |
Could you see if you could narrow it down to where it's failing? |
same with previous release -- I'll dig into it -- to board goes to safe mode! I'll also ping Danh |
I'm wondering if the issue is in this library or the ht16k33 library. |
the ht16k33 works for the 14segment on the feather_nrf52840 |
opened issue in CP adafruit/circuitpython#1545 |
as noted in the CP issue -- I can use this library on the feather_nrf52840 if I copy the contents of sevensegment_featherwing.py directly into the main file. here is my test
this executes on the feather_nrf52840 just fine -- I also ran the alphanum test the same way. |
based on the above, I have no concerns with this PR -- it remains to be resolved if the nrf52840 issue is with this library -- already existing or with CP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an issue with thsi library overall when used on an nrf52840 but with the workaround described in the comments, I can get everything to wok. It worked fine on the feather_m4_express. I will approve the PR since I don't think it is part of the larger issue.
Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.4.0 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#26 from makermelissa/master
Now the that last pull request has been moved along, here's the next one. This adds the 7-segment featherwing and gives it similar functionality to the alphanumeric one.