-
Notifications
You must be signed in to change notification settings - Fork 7
Add SPI Usage #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caternuson
requested changes
Nov 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One change, otherwise just some questions for clarification.
Basic functional check all good! [EDIT] - I changed CS in your example to 7, wanted to avoid using the shifted pin 5 output on Itsy Adafruit CircuitPython 3.1.1 on 2018-11-02; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import fram_spi_simpletest as test
bytearray(b'\x01')
>>> fram = test.fram
>>> fram[0] = 0x42
>>> fram[0]
bytearray(b'B')
>>> fram[0:4]
bytearray(b'B\x00\x00\x00')
>>> fram.write_protected
False
>>> fram.write_protected = True
>>> fram[0] = 0x23
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/lib/adafruit_fram.py", line 169, in __setitem__
RuntimeError: FRAM currently write protected.
>>> |
sommersoft
commented
Nov 27, 2018
caternuson
approved these changes
Nov 30, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 3, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.2.2 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#20 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#4 from sommersoft/spi_new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Add FRAM Library.
I SPI with my little i….
This also changes
write_protected()
setters. SPI had another layer, so I wanted to utilize that.