Skip to content

implement wifmanager and update examples #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2019
Merged

implement wifmanager and update examples #28

merged 3 commits into from
Feb 27, 2019

Conversation

jerryneedell
Copy link
Contributor

added support for wifimanager
updated examples

@jerryneedell jerryneedell requested review from makermelissa and a team February 27, 2019 17:49
makermelissa
makermelissa requested changes Feb 27, 2019
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this yet, but these are some initial changes I see.

adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py Outdated
`adafruit_espatcontrol_wifimanager`
================================================================================

WiFi Manager for making ESP32 SPI as WiFi much easier
Copy link
Collaborator

@makermelissa makermelissa Feb 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the name to "ESP AT Control" or something similar here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py Outdated

WiFi Manager for making ESP32 SPI as WiFi much easier

* Author(s): Melissa LeBlanc-Williams, ladyada
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add your name to this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py Outdated
"""
A class to help manage the Wifi connection
"""
def __init__(self, esp, secrets, status_pixel, attempts=2):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this needs to be fixed in ESP32SPI too, but it should be: status_pixel=None

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py.save Outdated
@@ -0,0 +1,216 @@
# The MIT License (MIT)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a duplicate file and should probably be removed from the commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@jerryneedell
Copy link
Contributor Author

tested with Feather_m4_express and feather huzzah32

@jerryneedell
Copy link
Contributor Author

also tested most functions on particle argon -- not sure if we want to add particle argon examples but I thought it best to get this PR in and released before adding argon specific examples.

@makermelissa
Copy link
Collaborator

Is this supposed to work with the ESP8266? I haven't tried it, but I'm trying to figure out which combination to try wiring up.

@jerryneedell
Copy link
Contributor Author

It should also work with ESP8266, but there will likely be more communication errors and retries.
I will do some testing

@makermelissa
Copy link
Collaborator

Is there firmware for the ESP32? Also, what is the wiring for say a Metro M4 and ESP32? I see the WiFi Co-Proc learning guide, but it has other hardware and I'm not quite sure what the equivalent to the GPIO0 is.

@jerryneedell
Copy link
Contributor Author

jerryneedell commented Feb 27, 2019 •
edited
Loading

posted AT firmware file to discord

flash with 
/usr/local/bin/esptool.py --chip esp32 --port /dev/ttyUSB0 --baud 115200 --before default_reset --after hard_reset write_flash -z --flash_mode dio --flash_freq 40m --flash_size detect 0 factory_WROOM-32.bin 
pins - 
VUSB - VUSB
GND - GND
RX - TX
TX -RX
D5 - ESP32 RESET
D6 - ESP32 GPIO15

GPIO is not needed

makermelissa
makermelissa approved these changes Feb 27, 2019
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with the localtime example on a Metro M4 + Huzzah32 and it seemed to work fine.

@makermelissa
Copy link
Collaborator

@jerryneedell, what is your confidence level on this? Should somebody else review it too or do you feel good about it?

@jerryneedell
Copy link
Contributor Author

I'm confident that it it works OK and have no concerns with merging or releasing it. That said, I'm also happy to give more time for other reviews/ comments. There is no rush.

@makermelissa
Copy link
Collaborator

Sounds good to me. I'd say let's merge it so people can start using it if they want.

@makermelissa makermelissa merged commit 7e60eb9 into adafruit:master Feb 27, 2019
@jerryneedell jerryneedell deleted the jerryn_wifi branch February 27, 2019 19:12
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 28, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@eab60b0)
d4b8b60 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.3.0 from 0.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#28 from jerryneedell/jerryn_wifi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryneedell @makermelissa