Skip to content

Add more HTTP request types to WiFiManager #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 19, 2019

Adding put/patch/delete methods from adafruit_esp32spi_requests to _wifimanager.

@brentru brentru requested review from makermelissa, jerryneedell and a team February 19, 2019 15:29
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can't do any testing today, but I don't have any concern with adding this. Thanks!

@makermelissa makermelissa merged commit ebcb723 into adafruit:master Feb 19, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 19, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#7 from brentru/expose-requests-more

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#12 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#10 from tannewt/update_for_4

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Bitmap_Font, Adafruit_CircuitPython_Display_Text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants