Add Access point mode #57

mscosti · 2019-07-07T22:05:23Z

Adds access point creation methods to esp32spi.py.
- Puts the ESP32 into AP mode so devices can connect to its own wifi local network.
- Can specify the SSID and an optional password for the network

Todo

More cleanup
Fix linting errors + get green build

- channel needed to be in hex byte format. - Add begining of a server example example program. - TODO: figure out why cannot create AP w/ passphrase

ladyada · 2019-07-09T01:57:17Z

i think this is a solid start. for making little servers, a 'micro Flask' could be a good way to create the structure for responding to queries. maybe we want to split this into two PRs, one for AP and one for server?

mscosti · 2019-07-11T01:35:42Z

I think having 2 PRs is fine, one with AP, one with server. The only hesitation I have is that one isn't very useful w/out the other. Does this repo get a new release with every commit/PR, or is release cut manually when we think think its time?

In that case, I'll make this branch and PR just for AP and take out the example code. I'll open a new branch and draft PR for server with what I have now and can continue working on fleshing that out more.

This reverts commit 130f966.

This reverts commit ea630d2.

This reverts commit c72cd97.

to be re-worked in future commits

ladyada · 2019-07-11T05:51:34Z

we can make releases whenever. server is useful without AP (but agree AP is not useful without server) so lets do server first :)

…Python_ESP32SPI into ap_mode

mscosti · 2019-07-12T22:50:15Z

Good to know. Server PR still has a lot more work to go into it, but I think this PR should be ready to go whenever we want, just because it's a simpler and more understood.

We can sit on it until Server PR is merged.

brentru

Looks promising (and something I'd use for a few of the CircuitPython IOT libraries!). Requesting a few changes..

brentru · 2019-07-16T15:58:26Z

adafruit_esp32spi/adafruit_esp32spi.py

@@ -409,6 +411,29 @@ def wifi_set_entenable(self):
        if resp[0][0] != 1:
            raise RuntimeError("Failed to enable enterprise mode")

+    def wifi_set_ap_network(self, ssid, channel):


Change to wifi_create_ap?

decided to leave this the same to match the name of the command we send to the ESP32 FW.

adafruit_esp32spi/adafruit_esp32spi.py

mscosti · 2019-07-16T17:00:20Z

Thanks for the feedback @brentru ! I'll try to address your suggestions tomorrow night, unfortunately the only time I have to work on project is in my free time (nights, weekends) and this week I have a bit going on on.

adafruit_esp32spi/adafruit_esp32spi.py

brentru · 2019-07-16T17:01:29Z

@mscosti No rush - great work so far!

adafruit_esp32spi/adafruit_esp32spi.py

…Python_ESP32SPI into ap_mode

mscosti · 2019-07-21T21:35:06Z

@brentru Thanks for the review! I have updated to incorporate your feedback, and responded to some of them.

siddacious

Just one little nit pick about disabling the line length lint checker, and a question about the delay time for the timeout. I'll test in a bit.

adafruit_esp32spi/adafruit_esp32spi_wifimanager.py

mscosti · 2019-07-23T20:11:39Z

I think this PR also has all currently requested changes made, and is ready for potential re-review.

brentru · 2019-07-23T21:13:18Z

@mscosti Just tested this, I'd like to suggest some things before we merge:

WiFiManager: create_ap should create an access point based on kwargs provided to it, a SSID and Password. I think people will use it this way
- Providing the AP setup information to create_ap instead of setting it in init.
- i.e: wifi.create_ap(SSID, PASS)
Let's add an example of creating an access point so people don't need to dig through WiFiManager (Add two calls in the example and comment one out. Show creating an insecure access point and one for creating a password-protected access point)

adafruit_esp32spi/adafruit_esp32spi_wifimanager.py

adafruit_esp32spi/adafruit_esp32spi.py

…Python_ESP32SPI into ap_mode

…rt AP without internet

mscosti · 2019-08-11T22:06:01Z

I fixed a bug, and added AP creation examples to the wsgi server demo code as options to use instead of connecting to wifi.

I also modified the web application to no longer depend on externally hosted static assets, since if you're connected to the esp32 hotspot, you likely don't have a way for your device to download those assets from the internet unless your device has already cached them. Now it will work regardless.

@brentru I haven't updated the method signature for create_AP to take in kwargs for ssid and pass, and still use secrets for getting it.

The reason I think its better to use secrets is that the wifimanager class currently expects a secrets object to be passed to it, and every method in it uses that. If we took in kwargs, then there was no point in passing in secrets to the constructor. I thought about supporting some sort of dual mode where you could use kwargs or secrets, but it felt clunky to me.

Curious what your thoughts are.

brentru · 2019-08-19T15:02:23Z

@mscosti Had the chance to test this AM. Works great with each of the AP examples you provided.

@brentru I haven't updated the method signature for create_AP to take in kwargs for ssid and pass, and still use secrets for getting it.

I like how AP creation works in your example - especially since it's contained within the init. for wifimanager as it's near the top of code near hardware initialization.

I thought about supporting some sort of dual mode where you could use kwargs or secrets, but it felt clunky to me.

Agreed, the way you have it right now isn't clunky and we can always add a dual-mode in later.

I'm going to merge this in and release, as you've made siddacious' requested changes too. Thank you for your patience with this PR.

Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#67 from dcbriccetti/gravity_pulls_pixel > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#66 from jepler/audiocore Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.8.0 from 1.7.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#57 from mscosti/ap_mode

mscosti and others added 5 commits June 29, 2019 00:37

add access point creation SPI commands and wifimanager helper

b9befbf

- Can now create AP w/out passphrase

45cf5c1

- channel needed to be in hex byte format. - Add begining of a server example example program. - TODO: figure out why cannot create AP w/ passphrase

attempt at start_server method

c72cd97

Working hello world server example

ea630d2

fix spacing

130f966

mscosti added 7 commits July 10, 2019 22:11

Revert "fix spacing"

832b79b

This reverts commit 130f966.

Revert "Working hello world server example"

06d7bd1

This reverts commit ea630d2.

Revert "attempt at start_server method"

02477df

This reverts commit c72cd97.

Add more docs and fix linting

f6e1695

remove server example

7a87e4e

to be re-worked in future commits

appease pylint

d0ee495

tabs -> spaces

f67a2e4

mscosti marked this pull request as ready for review July 11, 2019 03:02

This was referenced Jul 11, 2019

Add Server functionality #58

Closed

Add Server creation and management support #59

Merged

mscosti changed the title ~~Access point mode + Server methods/example~~ Add Access point mode Jul 11, 2019

Merge branch 'master' of https://github.com/adafruit/Adafruit_Circuit…

7c1eaac

…Python_ESP32SPI into ap_mode

brentru requested changes Jul 16, 2019

View reviewed changes

brentru reviewed Jul 16, 2019

View reviewed changes

adafruit_esp32spi/adafruit_esp32spi.py Outdated Show resolved Hide resolved

Address PR comments

917ef2d

mscosti commented Jul 21, 2019

View reviewed changes

adafruit_esp32spi/adafruit_esp32spi.py Show resolved Hide resolved

Merge branch 'master' of https://github.com/adafruit/Adafruit_Circuit…

d1c581f

…Python_ESP32SPI into ap_mode

siddacious suggested changes Jul 21, 2019

View reviewed changes

adafruit_esp32spi/adafruit_esp32spi_wifimanager.py Outdated Show resolved Hide resolved

wrap argument list instead of disabling lint rule

eb1a8b0

brentru requested changes Jul 23, 2019

View reviewed changes

mscosti added 4 commits July 26, 2019 19:38

Merge branch 'master' of https://github.com/adafruit/Adafruit_Circuit…

5a73905

…Python_ESP32SPI into ap_mode

fix valid SSID and passphrase requirements

180ceaa

add protected and unprotected AP code snippets to wsgi server demo

a349bac

make example web app not depend on externally hosted assets, to suppo…

bea04e4

…rt AP without internet

brentru approved these changes Aug 19, 2019

View reviewed changes

brentru merged commit ea860b2 into adafruit:master Aug 19, 2019

Add Access point mode #57

Add Access point mode #57

Uh oh!

Conversation

mscosti commented Jul 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Uh oh!

ladyada commented Jul 9, 2019

Uh oh!

mscosti commented Jul 11, 2019

Uh oh!

ladyada commented Jul 11, 2019

Uh oh!

mscosti commented Jul 12, 2019

Uh oh!

brentru left a comment

Choose a reason for hiding this comment

Uh oh!

brentru Jul 16, 2019

Choose a reason for hiding this comment

Uh oh!

mscosti Jul 21, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mscosti commented Jul 16, 2019

Uh oh!

Uh oh!

brentru commented Jul 16, 2019

Uh oh!

Uh oh!

mscosti commented Jul 21, 2019

Uh oh!

siddacious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mscosti commented Jul 23, 2019

Uh oh!

brentru commented Jul 23, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mscosti commented Aug 11, 2019

Uh oh!

brentru commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mscosti commented Jul 7, 2019 •

edited

Loading

brentru commented Aug 19, 2019 •

edited

Loading