Add RGB Status LED to WiFiManager #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
requested changes
Jun 11, 2019
| @@ -54,6 +55,9 @@ def __init__(self, esp, secrets, status_pixel=None, attempts=2): | |||
| self.attempts = attempts | |||
| requests.set_interface(self._esp) | |||
| self.statuspix = status_pixel | |||
| self._is_rgb_led = False | |||
There was a problem hiding this comment.
there is no need to have an additional variable to lose/keep track of, just do all tests in the function in question
ladyada
approved these changes
Jun 11, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 11, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#53 from brentru/expose-rgbled-status-wifimanager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the option of using an externally defined RGB LED (https://github.com/adafruit/Adafruit_CircuitPython_RGBLED) as a
status_pixelforWiFiManager. Useful for AirLift Breakout and FeatherWing.pixel_statushas been modified to setcolorbased on LED type.examples/esp32spi_aio_post.pyto show usage for a RGB LED.Tested with Feather M4 on CircuitPython 4.0.1, AirLift FeatherWing. Tested both constructing and passing
wifian RGB LEDstatus_pixeland a NeoPixelstatus_pixel.Addressing #47