Skip to content

add aio post and cheerlights examples #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2019
Merged

add aio post and cheerlights examples #3

merged 3 commits into from
Feb 13, 2019

Conversation

jerryneedell
Copy link
Contributor

Added a few examples including use of settings.py
@ladyada If you are working on better examples, feel free to close this PR -- I just thought I make them available.

@jerryneedell jerryneedell requested a review from ladyada February 13, 2019 13:47
makermelissa
makermelissa requested changes Feb 13, 2019
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files tested successfully. Only request is to change settings.py to esp32spi_settings.py (plus any references) because it triggers one of Kattni's scripts otherwise.

@jerryneedell
Copy link
Contributor Author

Thanks! good catch -- I'll make those changes

@ladyada
Copy link
Member

ladyada commented Feb 13, 2019

i think this is good! we will want a ESPSPI_WiFiManager helper class at some point, which does the instantiation and link management for ya. it could go in this library or separate (probably best to keep in this one since its so dependant on the hardware init)

@ladyada ladyada merged commit 2d1bd43 into adafruit:master Feb 13, 2019
@jerryneedell jerryneedell deleted the jerryn_examples branch February 13, 2019 18:07
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 14, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@5ea5ed2)
4b8a066 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#3 from jerryneedell/jerryn_examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#9 from jerryneedell/jerryn_mag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryneedell @ladyada @makermelissa