Skip to content

Expose the IP Address from WiFiManager #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Expose the IP Address from WiFiManager #16

merged 1 commit into from
Feb 27, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 26, 2019

Exposes the device's IP address from within WiFiManager.

Calling print(wifi.ip_address()) returns 10.0.0.000 (snipped to remove identifiers)

Tested on a PyPortal

@brentru brentru added the enhancement New feature or request label Feb 26, 2019
@brentru brentru requested review from makermelissa and a team February 26, 2019 23:37
siddacious
siddacious reviewed Feb 27, 2019
View reviewed changes
siddacious
siddacious reviewed Feb 27, 2019
View reviewed changes
Copy link
Contributor

@siddacious siddacious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above/below is just my $0.02. If this is how you would like it to work, thats fine.

@siddacious siddacious merged commit 3a5ae85 into adafruit:master Feb 27, 2019
@brentru brentru deleted the expose-ip-addr branch February 27, 2019 03:07
@makermelissa makermelissa mentioned this pull request Feb 27, 2019
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 27, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@eab60b0)
c0d8067 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.1 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#17 from brentru/update-comments-for-pixel
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#18 from brentru/expose-rssi
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#16 from brentru/expose-ip-addr
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#14 from makermelissa/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddacious siddacious siddacious approved these changes

@makermelissa makermelissa Awaiting requested review from makermelissa

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @siddacious