Fix #52 Distinguish stride from width for SSD1680 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestingFix verified for rotations 1 & 2 on a Raspberry Pi Zero W with Adafruit 2.13" E-ink Bonnet (graphics no longer shifted by 4 pixels). No regressions encountered with rotations 0 & 3. |
|
nice! thank you for the PR :) |
Apply fix from 8022b34 to Adafruit_SSD1680, allowing rotations of 1 and 2 to be used even when width is not a multiple of 8.
|
It looks like I neglected to cede control over hand formatting. Revised fix, reformatted by Black, in work. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 25, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.9.4 from 2.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#53 from cdmuhlb/issues/52-ssd1680-stride > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 3.2.0 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#45 from lesamouraipourpre/matrix5x5 > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.1.0 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#14 from jposada202020/correcting_docs > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#13 from dgriswo/main > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.5 from 2.18.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#152 from jposada202020/correcting_bitmaplabel_anchorpoint > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_NeoKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply fix from 8022b34 to Adafruit_SSD1680, allowing rotations of 1 and
2 to be used even when width is not a multiple of 8.