Skip to content

Add clear lut #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Add clear lut #10

wants to merge 12 commits into from

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Mar 16, 2021

I separated this out because it adds a new API: a method "clear" to the driver as well as the lut itself. You could replace a value before, and you could add new values (and in #6 I added the ability to remove a value by assigning None), but you couldn't remove/clear values.

If you think this is useful, merge it, otherwise please feel free to close it. It's less urgent now that I realized I could add a way to remove a single value by assigning = None.

builds on #7 (which builds on #6 and #9 )

@caternuson
Copy link
Contributor

It's less urgent now that I realized I could add a way to remove a single value by assigning = None.

That's probably the more Pythonic way to do this. Can you get everything done by just assigning None? Or can you think of another use case where a separate clear() methods is useful?

@rpavlik
Copy link
Contributor Author

rpavlik commented Mar 20, 2021

As long asyou can find out what values you set, the assigning none works, and I think you can find out the values you set.

@rpavlik rpavlik closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants