Make a _pixelbuf version of dotstar #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR requires formatting changes to be considered for merging. As well, there were changes to the CI which would cause issues with patching as it no longer matches the standard CI. Further, it appears that @dunkmann00 and @rhooper crossed paths. Closing in favor or #48. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can't be merged because the build is failing on black. I don't intend to fix that, because I can't bring myself to contribute code with function arguments formatted the way black wants them formatted.
Black also runs first, preventing visibility into other issues with sphinx and pylint.
I moved it to the end so it can be pesky last.
As such, I will submit this PR for reference only. I expect it to be rejected.