-
Notifications
You must be signed in to change notification settings - Fork 38
Add _pixelbuf support #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0275860
Import _pixelbuf/pypixelbuf variant
rhooper 198e70d
Fix import for new _pixelbuf api
rhooper 6efcd01
Merge branch 'master' into subclass
rhooper dd29815
subclass from Pixelbuf and add changes from master
rhooper 84f138f
fix docstring
rhooper 99d89ae
update pylintrc from cookiecutter
rhooper ba06384
make sphinx happy about pypixelbuf not existing yet
rhooper 0509ac9
use the native pixelbuf fill helper
rhooper 49f57d3
fix import - adafruit_pypixelbuf
rhooper d8a8fb1
Merge remote-tracking branch 'ada/master' into pixelbuf
rhooper 010e691
add adafruit-pypixelbuf to deps
rhooper a9c8fbb
copy pylintrc from master
rhooper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
'sphinx.ext.viewcode', | ||
] | ||
|
||
# autodoc_mock_imports = ["digitalio", "busio"] | ||
autodoc_mock_imports = ["pypixelbuf"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this needed? Can't the real version be installed from pypi? |
||
|
||
intersphinx_mapping = {'python': ('https://docs.python.org/3.4', None), | ||
'CircuitPython': ('https://circuitpython.readthedocs.io/en/latest/', None)} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
Adafruit-Blinka | ||
adafruit-circuitpython-busdevice | ||
adafruit-circuitpython-pypixelbuf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,8 @@ | |
author='Adafruit Industries', | ||
author_email='[email protected]', | ||
|
||
install_requires=['Adafruit-Blinka', 'adafruit-circuitpython-busdevice'], | ||
install_requires=['Adafruit-Blinka', 'adafruit-circuitpython-busdevice', | ||
'adafruit-circuitpython-pypixelbuf'], | ||
|
||
# Choose your license | ||
license='MIT', | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this example would be better to have in a separate example file. The example in the readme should be short and simple. Other examples can do fancier things.