Skip to content

Cookiecutter the library and update to match NeoPixel API. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2017
Merged

Cookiecutter the library and update to match NeoPixel API. #1

merged 3 commits into from
Sep 6, 2017

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 5, 2017

No description provided.

@tannewt tannewt requested a review from dhalbert September 6, 2017 00:52
dhalbert
dhalbert reviewed Sep 6, 2017
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the impl with the neopixel library, and it looks good and consistent (and different where necessary). I tried it with a strip of DotStars I have, and couldn't get it to work, but I think I have 5V/3.3v problems.

If the main file is named adafruit_dotstar.py, then it will need to be import adafruit_dotstar, no? Did you want to change the name like that?

@tannewt
Copy link
Member Author

tannewt commented Sep 6, 2017

Yeah, I want our libraries to have the adafruit_ prefix. neopixel is unique since its more prevalent already.

dhalbert
dhalbert requested changes Sep 6, 2017
View reviewed changes
adafruit_dotstar.py Outdated

.. code-block:: python

import dotstar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import adafruit_dotstar

adafruit_dotstar.py Outdated

RED = 0x100000

with dotstar.DotStar(APA102_SCK, APA102_MOSI, 1) as pixels:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with adafruit_dotstar.DotStar(...)

@dhalbert
Copy link
Contributor

dhalbert commented Sep 6, 2017

Got it re naming. So a couple of examples have to change in dotstar.py. Tnx.

@tannewt
Copy link
Member Author

tannewt commented Sep 6, 2017

Fixed up the example and deinit code. Tested by @kattni and I on the CircuitPlayground Express with DotStar strips.

@tannewt tannewt requested a review from kattni September 6, 2017 19:02
kattni
kattni approved these changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested the adafruit_dotstar library on a Circuit Playground Express with a strip of white Dotstars. Previous issues have been resolved.

@tannewt tannewt merged commit 14205d8 into adafruit:master Sep 6, 2017
kattni pushed a commit that referenced this pull request May 11, 2020
@dunkmann00
Merge pull request #1 from rhooper/pixelbuf-docs
d8f4d09 
doc fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert requested changes

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @dhalbert @kattni