Skip to content

add init #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020
Merged

add init #93

merged 1 commit into from
Oct 19, 2020

Conversation

eteq
Copy link
Contributor

@eteq eteq commented Oct 18, 2020

This is about as trivial as a PR comes (adding a blank file...), but it seemed to me this was necessary to get python setup.py install to work correctly to let this by useable on blinka/non-cirtcuitpython?

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a raspberry pi 3B+ I was able to install this library successfully with these commands

pip3 install adafruit-circuitpython-display-text

These also were working successfully for me:

git clone https://github.com/adafruit/Adafruit_CircuitPython_Display_Text.git
cd Adafruit_CircuitPython_Display_Text
sudo python3 setup.py install

In both cases I tested the install with a Blinka Displayio simpletest script for ili9341 screen.

Even though it does seem to be working for me as-is, I do think we probably want to include an __init__.py file like you've added so that it can be a proper python package.

Looking over at this library as an example: https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx/blob/master/adafruit_mcp230xx/__init__.py

I see that the empty init file does include a few license lines.

Can you add these to the file you created and make a new push please?

# SPDX-FileCopyrightText: 2019 Scott Shawcroft and Kevin Matocha for Adafruit Industries
#
# SPDX-License-Identifier: Unlicense

@tannewt
Copy link
Member

tannewt commented Oct 19, 2020

I don't think we need a license for an empty file. Nothing to license. :-)

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me now then. I did a quick test with the anchor point example with both label and bitmap_label and had no issues.

Thank you @eteq

@FoamyGuy FoamyGuy merged commit 0c57ae8 into adafruit:master Oct 19, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants