Add line_spacing property and change (0,0) definition #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tannewt this is the new version with center-M origin |
…ch is more realisticly described)
tannewt
requested changes
Mar 10, 2019
|
@tannewt i need to lint more |
tannewt
reviewed
Mar 12, 2019
adafruit_display_text/label.py
Outdated
| class TextArea(displayio.Group): | ||
| """An area displaying a string of textself. | ||
| class Label(displayio.Group): | ||
| """An area displaying a string of textself. The origin point set by ``x`` and ``y`` |
There was a problem hiding this comment.
Suggested change
| """An area displaying a string of textself. The origin point set by ``x`` and ``y`` | |
| """A label displaying a string of text. The origin point set by ``x`` and ``y`` |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 12, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP3xxx to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MCP3xxx#13 from yoomy3/fix-MCP3008-differential Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 2.0.0 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#13 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.0.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#5 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_INA260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the origin point of text areas is from the baseline of the font rather than the font's bounding box corner - that way changing fonts will not change the location of the text, only size and style
see this for definition of font baseline
https://printingpartners.files.wordpress.com/2017/12/font-diagram.png
see pygame which does the same (i think) https://nerdparadise.com/programming/pygame/part5
@tannewt its a breaking change so i'd like to do this soon if you're OK with it